Redhat Compatible Distro enabling and rpm resolver fixing#379
Merged
Conversation
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
…nditional statement Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for Red Hat Compatible Distro (RCD) as a new provider in the OS image composer, including configuration files, resolver improvements for complex RPM dependencies, and comprehensive test coverage.
Changes:
- Added RCD provider implementation with repository configuration and image building capabilities
- Enhanced RPM resolver to handle complex conditional dependencies with parentheses and "if" clauses
- Added XML metadata caching for debugging RPM repository operations
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/provider/rcd/rcd_test.go | Comprehensive test suite for RCD provider functionality |
| internal/provider/rcd/rcd.go | Core RCD provider implementation with Init, PreProcess, BuildImage, and PostProcess methods |
| internal/ospackage/rpmutils/resolver_test.go | Test cases for complex conditional dependency parsing |
| internal/ospackage/rpmutils/resolver.go | Enhanced dependency extraction logic and XML metadata caching |
| internal/ospackage/rpmutils/helper_test.go | Test cases for enhanced dependency name extraction |
| internal/ospackage/rpmutils/helper.go | Enhanced dependency name extraction with support for conditional dependencies |
| internal/config/schema/os-image-template.schema.json | Added redhat-compatible-distro to OS enum |
| internal/config/schema/os-config.schema.json | Added rcd10 to distribution enum |
| internal/chroot/rpm/installer.go | Added redhat-compatible-distro support for GPG key imports |
| image-templates/rcd10-x86_64-minimal-raw.yml | Minimal raw image template for RCD |
| config/osv/redhat-compatible-distro/rcd10/providerconfigs/*.yml | Repository configuration files for x86_64 and aarch64 |
| config/osv/redhat-compatible-distro/rcd10/imageconfigs/defaultconfigs/*.yml | Default image configurations for raw, ISO, and initrd images |
| config/osv/redhat-compatible-distro/rcd10/imageconfigs/additionalfiles/* | Additional configuration files for getty services and networking |
| config/osv/redhat-compatible-distro/rcd10/config.yml | OS configuration for x86_64 and aarch64 architectures |
| config/osv/redhat-compatible-distro/rcd10/chrootenvconfigs/* | Chroot environment configurations and local repository setup |
| cmd/os-image-composer/build.go | Registered RCD provider in build command |
Comments suppressed due to low confidence (1)
config/osv/redhat-compatible-distro/rcd10/providerconfigs/aarch64_64_repo.yml:1
- The filename 'aarch64_64_repo.yml' contains a typo with duplicate '64'. It should be 'aarch64_repo.yml' to match the pattern of 'x86_64_repo.yml'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
…installable Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
samueltaripin
force-pushed
the
rhel-enabling
branch
from
e5e9fc8 to
ece3942
Compare
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
samueltaripin
approved these changes
Feb 13, 2026
samueltaripin
approved these changes
Feb 13, 2026
Signed-off-by: Mah, Yock Gen <yock.gen.mah@intel.com>
srmungar
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR
Description
Redhat Compatible Distro CentOS Stream 10 enabling
Any Newly Introduced Dependencies
How Has This Been Tested?
Reproduce Steps:
Verified in qemu for both builds as below shown: